Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make percent cell declarative #479

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Mar 30, 2023

Rather than rely on a single numeric cell renderer, keep the cell types declarative an make the formatter the abstraction. This has the benefit that the formatters are cached outside of the closures and makes the tables a bit more declarative (easier to modify renderers independantly).

@mikeldking mikeldking merged commit f5372b3 into main Mar 30, 2023
@mikeldking mikeldking deleted the make-percent-column-declarative branch March 30, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants